xiaoxiang781216 commented on code in PR #7673: URL: https://github.com/apache/incubator-nuttx/pull/7673#discussion_r1031195267
########## drivers/virtio/Kconfig: ########## @@ -0,0 +1,33 @@ +# +# For a description of the syntax of this configuration file, +# see the file kconfig-language.txt in the NuttX tools repository. +# + +menuconfig DRIVERS_VIRTIO + bool "Virtio Device Support" + default n + +menuconfig DRIVERS_VIRTIO_BASE + hex "Virtio-mmio base address" + default 0x0 Review Comment: why not let caller pass the address to virtio_init to resolve this issue? I think it's better to address the architecture issue in early stage as much as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
