xiaoxiang781216 commented on code in PR #7678: URL: https://github.com/apache/incubator-nuttx/pull/7678#discussion_r1031228659
########## include/nuttx/segger/rtt.h: ########## @@ -0,0 +1,88 @@ +/**************************************************************************** + * include/nuttx/segger/rtt.h + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +#ifndef __INCLUDE_NUTTX_SEGGER_RTT_H +#define __INCLUDE_NUTTX_SEGGER_RTT_H + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> +#include <nuttx/streams.h> + +/**************************************************************************** + * Pre-processor Definitions + ****************************************************************************/ + +#ifdef CONFIG_SEGGER_RTT +#define rtt_write(stream, buf, len) \ + stream->output.puts((FAR struct lib_outstream_s *)stream, buf, len) +#define rtt_putc(stream, ch) \ + stream->output.putc(((FAR struct lib_outstream_s *))stream, ch) +#define rtt_getc(stream) stream->input.getc() +#else +#define rtt_write(stream, buf, len) +#define rtt_putc(stream, ch) +#define rtt_getc(stream) +#endif + +/**************************************************************************** + * Type Declarations + ****************************************************************************/ + +struct lib_rttstream_s +{ + struct lib_outstream_s output; + struct lib_instream_s input; + int channel; +}; + +/**************************************************************************** + * Public Function Prototypes + ****************************************************************************/ + +#ifdef __cplusplus +extern "C" +{ +#endif + +/**************************************************************************** +* Name: rtt_channel_initialize +*****************************************************************************/ + +#ifdef CONFIG_SEGGER_RTT +void rtt_channel_initialize(int channel, FAR char *name, size_t upsize, Review Comment: move to new patch ########## include/nuttx/segger/rtt.h: ########## @@ -0,0 +1,88 @@ +/**************************************************************************** + * include/nuttx/segger/rtt.h + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +#ifndef __INCLUDE_NUTTX_SEGGER_RTT_H +#define __INCLUDE_NUTTX_SEGGER_RTT_H + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> +#include <nuttx/streams.h> + +/**************************************************************************** + * Pre-processor Definitions + ****************************************************************************/ + +#ifdef CONFIG_SEGGER_RTT +#define rtt_write(stream, buf, len) \ Review Comment: create a new patch for the general macro wrapper and move to nuttx/streams.h ########## drivers/drivers_initialize.c: ########## @@ -68,6 +69,16 @@ void drivers_initialize(void) devnull_register(); /* Standard /dev/null */ #endif +#if defined(CONFIG_RTT_CHANNEL1) Review Comment: move to new patch ########## drivers/segger/Kconfig: ########## @@ -77,6 +79,50 @@ config SEGGER_RTT_MODE_BLOCK_IF_FIFO_FULL endchoice # SEGGER_RTT_MODE +endif + +config RTT_CHANNEL1 Review Comment: move to new patch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
