lucasssvaz commented on code in PR #7693:
URL: https://github.com/apache/nuttx/pull/7693#discussion_r1032316041
##########
boards/xtensa/esp32/esp32-wrover-kit/include/board.h:
##########
@@ -53,18 +53,39 @@
#define BOARD_LED1 0
#define BOARD_LED2 1
#define BOARD_LED3 2
-#define BOARD_NLEDS 3
-#define BOARD_LED_RED BOARD_LED1
-#define BOARD_LED_GREEN BOARD_LED2
-#define BOARD_LED_BLUE BOARD_LED3
+#define BOARD_LED_RED BOARD_LED1 // GPIO 0
+#define BOARD_LED_GREEN BOARD_LED2 // GPIO 2
+#define BOARD_LED_BLUE BOARD_LED3 // GPIO 4
/* LED bits for use with autoleds */
#define BOARD_LED1_BIT (1 << BOARD_LED1)
#define BOARD_LED2_BIT (1 << BOARD_LED2)
#define BOARD_LED3_BIT (1 << BOARD_LED3)
+// GPIO 2 is used by MMCSD driver as MISO, therefore, it can't be used as USER
LED
+#ifdef CONFIG_MMCSD
+
+// GPIO 0 is used by BUTTONS, it can't be used as USER LED
Review Comment:
```suggestion
/* GPIO 0 is used by BUTTONS, it can't be used as USER LED */
```
##########
boards/xtensa/esp32/esp32-wrover-kit/include/board.h:
##########
@@ -53,18 +53,39 @@
#define BOARD_LED1 0
#define BOARD_LED2 1
#define BOARD_LED3 2
-#define BOARD_NLEDS 3
-#define BOARD_LED_RED BOARD_LED1
-#define BOARD_LED_GREEN BOARD_LED2
-#define BOARD_LED_BLUE BOARD_LED3
+#define BOARD_LED_RED BOARD_LED1 // GPIO 0
+#define BOARD_LED_GREEN BOARD_LED2 // GPIO 2
+#define BOARD_LED_BLUE BOARD_LED3 // GPIO 4
Review Comment:
```suggestion
#define BOARD_LED_RED BOARD_LED1 /* GPIO 0 */
#define BOARD_LED_GREEN BOARD_LED2 /* GPIO 2 */
#define BOARD_LED_BLUE BOARD_LED3 /* GPIO 4 */
```
##########
boards/xtensa/esp32/esp32-wrover-kit/src/esp32_userleds.c:
##########
@@ -42,7 +42,26 @@
static const uint32_t g_ledcfg[BOARD_NLEDS] =
{
+// GPIO 2 is used by MMCSD driver as MISO, therefore, it can't be used as USER
LED
+#ifdef CONFIG_MMCSD
+
+// GPIO 0 is used by BUTTONS, it can't be used as USER LED
Review Comment:
```suggestion
/* GPIO 0 is used by BUTTONS, it can't be used as USER LED */
```
##########
boards/xtensa/esp32/esp32-wrover-kit/include/board.h:
##########
@@ -53,18 +53,39 @@
#define BOARD_LED1 0
#define BOARD_LED2 1
#define BOARD_LED3 2
-#define BOARD_NLEDS 3
-#define BOARD_LED_RED BOARD_LED1
-#define BOARD_LED_GREEN BOARD_LED2
-#define BOARD_LED_BLUE BOARD_LED3
+#define BOARD_LED_RED BOARD_LED1 // GPIO 0
+#define BOARD_LED_GREEN BOARD_LED2 // GPIO 2
+#define BOARD_LED_BLUE BOARD_LED3 // GPIO 4
/* LED bits for use with autoleds */
#define BOARD_LED1_BIT (1 << BOARD_LED1)
#define BOARD_LED2_BIT (1 << BOARD_LED2)
#define BOARD_LED3_BIT (1 << BOARD_LED3)
+// GPIO 2 is used by MMCSD driver as MISO, therefore, it can't be used as USER
LED
+#ifdef CONFIG_MMCSD
+
+// GPIO 0 is used by BUTTONS, it can't be used as USER LED
+#ifdef CONFIG_INPUT_BUTTONS
+#define BOARD_NLEDS 1
+#else
+#define BOARD_NLEDS 2
+#endif
+
+#else // MMCSD
+
+// GPIO 0 is used by BUTTONS, it can't be used as USER LED
+#ifdef CONFIG_INPUT_BUTTONS
+#define BOARD_NLEDS 2
+#else
+#define BOARD_NLEDS 3
+#endif
+
+#endif
+
+
Review Comment:
```suggestion
```
##########
boards/xtensa/esp32/esp32-wrover-kit/src/esp32_userleds.c:
##########
@@ -42,7 +42,26 @@
static const uint32_t g_ledcfg[BOARD_NLEDS] =
{
+// GPIO 2 is used by MMCSD driver as MISO, therefore, it can't be used as USER
LED
+#ifdef CONFIG_MMCSD
+
+// GPIO 0 is used by BUTTONS, it can't be used as USER LED
+#ifdef CONFIG_INPUT_BUTTONS
+ GPIO_LED3
+#else
+ GPIO_LED1, GPIO_LED3
+#endif
+
+#else // MMCSD
Review Comment:
```suggestion
#else /* MMCSD */
```
##########
boards/xtensa/esp32/esp32-wrover-kit/include/board.h:
##########
@@ -53,18 +53,39 @@
#define BOARD_LED1 0
#define BOARD_LED2 1
#define BOARD_LED3 2
-#define BOARD_NLEDS 3
-#define BOARD_LED_RED BOARD_LED1
-#define BOARD_LED_GREEN BOARD_LED2
-#define BOARD_LED_BLUE BOARD_LED3
+#define BOARD_LED_RED BOARD_LED1 // GPIO 0
+#define BOARD_LED_GREEN BOARD_LED2 // GPIO 2
+#define BOARD_LED_BLUE BOARD_LED3 // GPIO 4
/* LED bits for use with autoleds */
#define BOARD_LED1_BIT (1 << BOARD_LED1)
#define BOARD_LED2_BIT (1 << BOARD_LED2)
#define BOARD_LED3_BIT (1 << BOARD_LED3)
+// GPIO 2 is used by MMCSD driver as MISO, therefore, it can't be used as USER
LED
Review Comment:
```suggestion
/* GPIO 2 is used by MMCSD driver as MISO, therefore, it can't be used as
* USER LED
*/
```
##########
boards/xtensa/esp32/esp32-wrover-kit/src/esp32_userleds.c:
##########
@@ -42,7 +42,26 @@
static const uint32_t g_ledcfg[BOARD_NLEDS] =
{
+// GPIO 2 is used by MMCSD driver as MISO, therefore, it can't be used as USER
LED
+#ifdef CONFIG_MMCSD
+
+// GPIO 0 is used by BUTTONS, it can't be used as USER LED
+#ifdef CONFIG_INPUT_BUTTONS
+ GPIO_LED3
+#else
+ GPIO_LED1, GPIO_LED3
+#endif
+
+#else // MMCSD
+
+// GPIO 0 is used by BUTTONS, it can't be used as USER LED
Review Comment:
```suggestion
/* GPIO 0 is used by BUTTONS, it can't be used as USER LED */
```
##########
boards/xtensa/esp32/esp32-wrover-kit/include/board.h:
##########
@@ -53,18 +53,39 @@
#define BOARD_LED1 0
#define BOARD_LED2 1
#define BOARD_LED3 2
-#define BOARD_NLEDS 3
-#define BOARD_LED_RED BOARD_LED1
-#define BOARD_LED_GREEN BOARD_LED2
-#define BOARD_LED_BLUE BOARD_LED3
+#define BOARD_LED_RED BOARD_LED1 // GPIO 0
+#define BOARD_LED_GREEN BOARD_LED2 // GPIO 2
+#define BOARD_LED_BLUE BOARD_LED3 // GPIO 4
/* LED bits for use with autoleds */
#define BOARD_LED1_BIT (1 << BOARD_LED1)
#define BOARD_LED2_BIT (1 << BOARD_LED2)
#define BOARD_LED3_BIT (1 << BOARD_LED3)
+// GPIO 2 is used by MMCSD driver as MISO, therefore, it can't be used as USER
LED
+#ifdef CONFIG_MMCSD
+
+// GPIO 0 is used by BUTTONS, it can't be used as USER LED
+#ifdef CONFIG_INPUT_BUTTONS
+#define BOARD_NLEDS 1
+#else
+#define BOARD_NLEDS 2
+#endif
+
+#else // MMCSD
+
+// GPIO 0 is used by BUTTONS, it can't be used as USER LED
Review Comment:
```suggestion
/* GPIO 0 is used by BUTTONS, it can't be used as USER LED */
```
##########
boards/xtensa/esp32/esp32-wrover-kit/include/board.h:
##########
@@ -53,18 +53,39 @@
#define BOARD_LED1 0
#define BOARD_LED2 1
#define BOARD_LED3 2
-#define BOARD_NLEDS 3
-#define BOARD_LED_RED BOARD_LED1
-#define BOARD_LED_GREEN BOARD_LED2
-#define BOARD_LED_BLUE BOARD_LED3
+#define BOARD_LED_RED BOARD_LED1 // GPIO 0
+#define BOARD_LED_GREEN BOARD_LED2 // GPIO 2
+#define BOARD_LED_BLUE BOARD_LED3 // GPIO 4
/* LED bits for use with autoleds */
#define BOARD_LED1_BIT (1 << BOARD_LED1)
#define BOARD_LED2_BIT (1 << BOARD_LED2)
#define BOARD_LED3_BIT (1 << BOARD_LED3)
+// GPIO 2 is used by MMCSD driver as MISO, therefore, it can't be used as USER
LED
+#ifdef CONFIG_MMCSD
+
+// GPIO 0 is used by BUTTONS, it can't be used as USER LED
+#ifdef CONFIG_INPUT_BUTTONS
+#define BOARD_NLEDS 1
+#else
+#define BOARD_NLEDS 2
+#endif
+
+#else // MMCSD
Review Comment:
```suggestion
#else /* MMCSD */
```
##########
boards/xtensa/esp32/esp32-wrover-kit/src/esp32_userleds.c:
##########
@@ -42,7 +42,26 @@
static const uint32_t g_ledcfg[BOARD_NLEDS] =
{
+// GPIO 2 is used by MMCSD driver as MISO, therefore, it can't be used as USER
LED
Review Comment:
```suggestion
/* GPIO 2 is used by MMCSD driver as MISO, therefore, it can't be used as
* USER LED
*/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
