pkarashchenko commented on code in PR #7702:
URL: https://github.com/apache/nuttx/pull/7702#discussion_r1033019078
##########
arch/arm/src/sama5/Kconfig:
##########
@@ -3230,6 +3230,7 @@ config SAMA5_ADC_DMASAMPLES
config SAMA5_ADC_AUTOCALIB
bool "ADC auto-calibration"
+ depends on ARCH_CHIP_SAMA5D3
Review Comment:
TABs
##########
arch/arm/src/sama5/Kconfig:
##########
@@ -3487,6 +3490,7 @@ config SAMA5_ADC_OFFSET11
endmenu # Channel offsets
menu "Channel differential mode"
+ depends on ARCH_CHIP_SAMA5D2 || ARCH_CHIP_SAMA5D3
Review Comment:
TABs
##########
arch/arm/src/sama5/Kconfig:
##########
@@ -3246,11 +3247,12 @@ config SAMA5_ADC_ANARCH
default n
---help---
This option allows you to select different gain, offset, and
single
- vs. differential modes for each channel.
+ vs. differential modes for each channel, depending on ARCH.
if SAMA5_ADC_ANARCH
menu "Channel gain"
+ depends on ARCH_CHIP_SAMA5D
Review Comment:
TABs
##########
arch/arm/src/sama5/Kconfig:
##########
@@ -3580,25 +3584,28 @@ if !SAMA5_ADC_ANARCH
config SAMA5_ADC_GAIN
int "Analog gain"
default 1
- depends on SAMA5_ADC_CHAN0
+ depends on ARCH_CHIP_SAMA5D3
range 0 3
---help---
Valid gain settings are {0, 1, 2, 3} which may be interpreted as
either {1, 1, 2, 4} if the channels are configured for single
ended
mode or as {0.5, 1, 2, 2} if the channels are configured for
- differential mode.
+ differential mode. Applies to all channels.
config SAMA5_ADC_OFFSET
bool "Offset"
default n
+ depends on ARCH_CHIP_SAMA5D3
Review Comment:
TABs
##########
arch/arm/src/sama5/Kconfig:
##########
@@ -3387,6 +3389,7 @@ config SAMA5_ADC_GAIN11
endmenu # Channel gain
menu "Channel offsets"
+ depends on ARCH_CHIP_SAMA5D3
Review Comment:
TABs
##########
arch/arm/src/sama5/Kconfig:
##########
@@ -3712,6 +3763,17 @@ config SAMA5_ADC_TIOA_BOTH
endchoice # ADTRG edge
endif # SAMA5_ADC_TIOATRIG
+
+if SAMA5_ADC_PERIODIC_TRIG
+
+config SAMA5_ADC_TRIGGER_PERIOD
+ int "ADC Periodic Trigger Rate, useconds"
+ default 50000
+ ---help---
+ This setting determines the periodic sample trigger rate in useconds.
Review Comment:
TABs
##########
arch/arm/src/sama5/Kconfig:
##########
@@ -3627,12 +3644,45 @@ config SAMA5_ADC_TIOATRIG
A-to-D Conversion is initiated the A output from one of
Timer/Counter 0 channels.
+config SAMA5_ADC_PWMTRIG
+ bool "PWM Event trigger"
+ depends on SAMA5_PWM
+ ---help---
+ A-to-D Conversion is initiated from the PWM event lines
+
+config SAMA5_ADC_RTCOUT
+ bool "RTC Out trigger"
+ depends on SAMA5_RTC
+ depends on ARCH_CHIP_SAMA5D2
+ ---help---
+ A-to-D Conversion is initiated from the RTC output
+
Review Comment:
TABs
##########
arch/arm/src/sama5/Kconfig:
##########
@@ -3627,12 +3644,45 @@ config SAMA5_ADC_TIOATRIG
A-to-D Conversion is initiated the A output from one of
Timer/Counter 0 channels.
+config SAMA5_ADC_PWMTRIG
+ bool "PWM Event trigger"
+ depends on SAMA5_PWM
+ ---help---
+ A-to-D Conversion is initiated from the PWM event lines
+
+config SAMA5_ADC_RTCOUT
+ bool "RTC Out trigger"
+ depends on SAMA5_RTC
+ depends on ARCH_CHIP_SAMA5D2
+ ---help---
+ A-to-D Conversion is initiated from the RTC output
+
endchoice # Trigger mode
+if SAMA5_ADC_PWMTRIG
+
+choice
+ prompt "PWM Event Line Selection"
+ default SAMA5_ADC_PWMTRIG_LINE0
+
+config SAMA5_ADC_PWM_TRIG_LINE0
+ bool "PWM event Line 0"
+ ---help---
+ Trigger A-to-D conversion on PWM event line 0
+
+config SAMA5_ADC_PWM_TRIG_LINE1
+ bool "PWM event Line 1"
+ ---help---
+ Trigger A-to-D conversion on PWM event line 1
+
+endchoice # PWM Event Line Selection
+endif # SAMA5_ADC_PWMTRIG
+
+if SAMA5_ADC_ADTRG || SAMA5_ADC_TIOATRIG || SAMA5_ADC_PWMTRIG ||
SAMA5_ADC_RTCOUT
+
Review Comment:
TABs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
