xiaoxiang781216 commented on code in PR #7715:
URL: https://github.com/apache/nuttx/pull/7715#discussion_r1033660318


##########
libs/libc/stream/lib_blkoutstream.c:
##########
@@ -217,6 +227,7 @@ int lib_blkoutstream_open(FAR struct lib_blkoutstream_s 
*stream,
     }
 
   stream->inode        = inode;
+  stream->public.put   = blkoutstream_putc;

Review Comment:
   It's little bit inconsistent in the original code base:
   
   1. The user see the function as lib_stream_put or lib_outstream_s::put
   2. The implementation normally name xxx_putc as statical function
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to