wengzhe commented on code in PR #7750: URL: https://github.com/apache/nuttx/pull/7750#discussion_r1037749433
########## net/icmpv6/icmpv6_reply.c: ########## @@ -112,15 +112,19 @@ void icmpv6_reply(FAR struct net_driver_s *dev, int type, int code, int data) dev->d_len = ipicmplen + datalen; + /* Copy fields from original packet */ + + memmove(icmpv6 + 1, ipv6, datalen); Review Comment: It's skipping the whole header, to copy origin packet as the payload of icmpv6. It's removed by accident and I'm just restoring the code from [previous version](https://github.com/apache/nuttx/blob/releases/11.0/net/icmpv6/icmpv6_reply.c#L117-L119). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
