xiaoxiang781216 commented on code in PR #1407:
URL: https://github.com/apache/nuttx-apps/pull/1407#discussion_r1037922304
##########
Make.defs:
##########
@@ -85,14 +80,24 @@ endif
BUILTIN_REGISTRY = $(APPDIR)$(DELIM)builtin$(DELIM)registry
DEPCONFIG = $(TOPDIR)$(DELIM).config
+ifeq ($(CONFIG_WINDOWS_NATIVE),y)
define REGISTER
$(Q) echo Register: $1
- $(Q) echo { \"$1\", $2, $3, $4 }, > "$(BUILTIN_REGISTRY)$(DELIM)$1.bdat"
+ $(Q) echo { "$(subst ",,$(1))", $2, $3, $(subst ",,$(4)) }, >
"$(BUILTIN_REGISTRY)$(DELIM)$1.bdat"
+ $(Q) echo int $(subst ",,$(4))(int argc, char *argv[]); >
"$(BUILTIN_REGISTRY)$(DELIM)$1.pdat"
+
+ $(Q) touch $(BUILTIN_REGISTRY)$(DELIM).updated"
+endef
+else
+define REGISTER
+ $(Q) echo "Register: $1"
+ $(Q) echo "{ \"$1\", $2, $3, $4 }," >
"$(BUILTIN_REGISTRY)$(DELIM)$1.bdat"
Review Comment:
can we share the same code, the difference look like very small.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
