TimJTi commented on code in PR #7702:
URL: https://github.com/apache/nuttx/pull/7702#discussion_r1038765865
##########
arch/arm/src/sama5/sam_adc.c:
##########
@@ -865,7 +935,7 @@ static void sam_adc_endconversion(void *arg)
int ret;
DEBUGASSERT(priv != NULL);
- ainfo("pending=%08x\n", priv->pending);
+ ainfo("pending=%08lx\n", priv->pending);
Review Comment:
That discussion is slightly beyond me, but I'm trying to understand if using
%08lx is actually WRONG rather than just a difference in approach. We *can* use
C99 in arch but don't HAVE to? I have always used the %08x type formatters,
probably because I learnt C back in the 1980's (K&R!).
I am not trying to be difficult, but need to make sure that any PR I submit
100% meets the rules, ideally first time! If it's "just" a suggestion that it
is "better" to do something using a different method I am always happy to
listen and learn, but need to know if that's what it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
