[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #7761: SAMA5D2 TDC, ADC and TC Corrections

[GitBox]

pkarashchenko commented on code in PR #7761:
URL: https://github.com/apache/nuttx/pull/7761#discussion_r1039498071


##########
arch/arm/src/sama5/sam_tc.c:
##########
@@ -1263,11 +1264,11 @@ void sam_tc_setregister(TC_HANDLE handle, int regid, 
uint32_t regval)
 
   DEBUGASSERT(chan && regid < TC_NREGISTERS);
 
-  tmrinfo("Channel %d: Set register RC%d to %08lx\n",
-          chan->chan, regid, (unsigned long)regval);
+  tmrinfo("Channel %d: Set register RC%d to %08lx"\n",
+           chan->chan, regid, (unsigned long)regval);

Review Comment:
   ```suggestion
             chan->chan, regid, (unsigned long)regval);
   ```



##########
arch/arm/src/sama5/sam_tc.c:
##########
@@ -1263,11 +1264,11 @@ void sam_tc_setregister(TC_HANDLE handle, int regid, 
uint32_t regval)
 
   DEBUGASSERT(chan && regid < TC_NREGISTERS);
 
-  tmrinfo("Channel %d: Set register RC%d to %08lx\n",
-          chan->chan, regid, (unsigned long)regval);
+  tmrinfo("Channel %d: Set register RC%d to %08lx"\n",

Review Comment:
   ```suggestion
     tmrinfo("Channel %d: Set register RC%d to %08lx\n",
   ```



##########
arch/arm/src/sama5/sam_tc.c:
##########
@@ -1443,19 +1445,19 @@ int sam_tc_divisor(uint32_t frequency, uint32_t *div, 
uint32_t *tcclks)
   if (div)
     {
       uint32_t value = sam_tc_freqdiv_lookup(ftcin, ndx);
-      tmrinfo("return div=%lu\n", (unsigned long)value);
+      tmrinfo("return div=%lu\n", (unsigned long) value);

Review Comment:
   ```suggestion
         tmrinfo("return div=%lu\n", (unsigned long)value);
   ```



##########
arch/arm/src/sama5/sam_tc.c:
##########
@@ -1443,19 +1445,19 @@ int sam_tc_divisor(uint32_t frequency, uint32_t *div, 
uint32_t *tcclks)
   if (div)
     {
       uint32_t value = sam_tc_freqdiv_lookup(ftcin, ndx);
-      tmrinfo("return div=%lu\n", (unsigned long)value);
+      tmrinfo("return div=%lu\n", (unsigned long) value);
       *div = value;
     }
 
   /* Return the TCCLKS selection */
 
   if (tcclks)
     {
-      tmrinfo("return tcclks=%08lx\n", (unsigned long)TC_CMR_TCCLKS(ndx));
+      tmrinfo("return tcclks=%08lx\n", (unsigned long) TC_CMR_TCCLKS(ndx));

Review Comment:
   ```suggestion
         tmrinfo("return tcclks=%08lx\n", (unsigned long)TC_CMR_TCCLKS(ndx));
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org