anchao commented on code in PR #7789:
URL: https://github.com/apache/nuttx/pull/7789#discussion_r1039913098


##########
net/icmpv6/icmpv6_input.c:
##########
@@ -336,10 +336,12 @@ void icmpv6_input(FAR struct net_driver_s *dev, unsigned 
int iplen)
 
                     if ((prefixopt->flags & ICMPv6_PRFX_FLAG_A) != 0)
                       {
+                        FAR void *addr = prefixopt->prefix;

Review Comment:
   emm.... It seems that packed struct is not a good solution, there are still 
many warnings of `Werror=address-of-packed-member`, If the `prefix` needs to be 
copied, I think which need to consider other ways to fix this issue, Let me 
revert related changes, thanks for the advice!  @gustavonihei @pkarashchenko 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to