XinStellaris commented on code in PR #7808:
URL: https://github.com/apache/nuttx/pull/7808#discussion_r1042853856
##########
arch/arm/src/common/arm_assert.c:
##########
@@ -520,39 +489,12 @@ void up_assert(const char *filename, int lineno)
{
board_autoled_on(LED_ASSERTION);
Review Comment:
I tried to move board_autoled_on into common code.
But after some experiments, I think it may not be the best idea:
1. some arch didn't call board_autoled_on, so this is not a common action(
sim , ceva and so on)
2. it needs to #include <arch/board/board.h> for LED_ASSERTION definition,
which seems strange in kernel code.
3. stm32 will not be compiled correctly after including arch/board/board.h
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
