[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #7776: Minor change for video framebuff

[GitBox]

pkarashchenko commented on code in PR #7776:
URL: https://github.com/apache/nuttx/pull/7776#discussion_r1043138737


##########
drivers/video/video_framebuff.c:
##########
@@ -97,12 +82,8 @@ static inline vbuf_container_t 
*dequeue_vbuf_unsafe(video_framebuff_t *fbuf)
 
 void video_framebuff_init(video_framebuff_t *fbuf)
 {
-  fbuf->mode       = V4L2_BUF_MODE_RING;
-  fbuf->vbuf_empty = NULL;
-  fbuf->vbuf_top   = NULL;
-  fbuf->vbuf_tail  = NULL;
-  fbuf->vbuf_next  = NULL;
-
+  memset(fbuf, 0, sizeof(*fbuf));

Review Comment:
   optional
   ```suggestion
     memset(fbuf, 0, sizeof(video_framebuff_t));
   ```



##########
drivers/video/video_framebuff.c:
##########
@@ -114,34 +95,27 @@ void video_framebuff_uninit(video_framebuff_t *fbuf)
 
 int video_framebuff_realloc_container(video_framebuff_t *fbuf, int sz)
 {
-  if (fbuf->vbuf_alloced == NULL || fbuf->container_size != sz)
-    {
-      if (fbuf->container_size != sz)
-        {
-          if (fbuf->vbuf_alloced != NULL)
-            {
-              kmm_free(fbuf->vbuf_alloced);
-            }
+  vbuf_container_t *vbuf;
 
-          fbuf->vbuf_alloced   = NULL;
-          fbuf->container_size = 0;
-        }
-
-      if (sz > 0)
-        {
-          fbuf->vbuf_alloced
-           = (vbuf_container_t *)kmm_malloc(sizeof(vbuf_container_t)*sz);
-          if (fbuf->vbuf_alloced == NULL)
-            {
-              return -ENOMEM;
-            }
-        }
+  if (fbuf->container_size == sz)
+    {
+      return OK;
+    }
 
-      fbuf->container_size = sz;
+  vbuf = kmm_realloc(fbuf->vbuf_alloced, sizeof(vbuf_container_t) * sz);

Review Comment:
   what if `sz` is zero?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org