XinStellaris commented on code in PR #7808: URL: https://github.com/apache/nuttx/pull/7808#discussion_r1045339088
########## arch/avr/src/common/avr_assert.c: ########## @@ -23,102 +23,12 @@ ****************************************************************************/ #include <nuttx/config.h> - -#include <stdint.h> -#include <stdlib.h> -#include <assert.h> -#include <debug.h> Review Comment: This is because some arch(such as arm64_assert.c) put dump logic in xxx_assert.c, while some (such as mips_assert.c) put dump logic in another xxxx_dumpstate.c. Unless we move all dump state logic into a common file, include files cannot be removed. As I have mentioned before, moving all dump state logic together will be in another patch (Lots of work). So how about we focus on common logic other than dump state in this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
