raiden00pl commented on code in PR #1460: URL: https://github.com/apache/nuttx-apps/pull/1460#discussion_r1051650505
########## logging/nxscope/nxscope_iser.c: ########## @@ -0,0 +1,248 @@ +/**************************************************************************** + * apps/logging/nxscope/nxscope_iser.c + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> + +#include <debug.h> +#include <fcntl.h> +#include <stdio.h> +#include <stdlib.h> +#include <termios.h> +#include <unistd.h> + +#include <logging/nxscope/nxscope.h> + +/**************************************************************************** + * Pre-processor Definitions + ****************************************************************************/ + +#ifndef CONFIG_SERIAL_TERMIOS +# error +#endif + +/**************************************************************************** + * Private Type Definition + ****************************************************************************/ + +struct nxscope_intf_ser_s +{ + FAR struct nxscope_ser_cfg_s *cfg; + int fd; +}; + +/**************************************************************************** + * Private Function Protototypes + ****************************************************************************/ + +static int nxscope_ser_send(FAR struct nxscope_intf_s *intf, + FAR uint8_t *buff, int len); +static int nxscope_ser_recv(FAR struct nxscope_intf_s *intf, + FAR uint8_t *buff, int len); + +/**************************************************************************** + * Private Data + ****************************************************************************/ + +struct nxscope_intf_ops_s g_nxscope_ser_ops = +{ + .send = nxscope_ser_send, + .recv = nxscope_ser_recv +}; + +/**************************************************************************** + * Private Functions + ****************************************************************************/ + +/**************************************************************************** + * Name: nxscope_ser_send + ****************************************************************************/ + +static int nxscope_ser_send(FAR struct nxscope_intf_s *intf, + FAR uint8_t *buff, int len) +{ + FAR struct nxscope_intf_ser_s *priv = NULL; + + DEBUGASSERT(intf); + DEBUGASSERT(intf->priv); + + /* Get priv data */ + + priv = (FAR struct nxscope_intf_ser_s *) intf->priv; + + /* Write data */ + + return write(priv->fd, buff, len); +} + +/**************************************************************************** + * Name: nxscope_ser_recv + ****************************************************************************/ + +static int nxscope_ser_recv(FAR struct nxscope_intf_s *intf, + FAR uint8_t *buff, int len) +{ + FAR struct nxscope_intf_ser_s *priv = NULL; + int ret = OK; + + DEBUGASSERT(intf); + DEBUGASSERT(intf->priv); + + /* Get priv data */ + + priv = (FAR struct nxscope_intf_ser_s *) intf->priv; + + /* Read data */ + + ret = read(priv->fd, buff, len); + + if (ret < 0) + { + if ((priv->cfg->nonblock == true) && (errno == EAGAIN)) + { + ret = 0; Review Comment: We read 0 bytes, so I think 0 is more suitable here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
