xiaoxiang781216 commented on code in PR #7908:
URL: https://github.com/apache/nuttx/pull/7908#discussion_r1053933166


##########
arch/arm/src/samv7/sam_eefc.c:
##########
@@ -66,6 +66,20 @@
  * Private Functions
  ****************************************************************************/
 
+static uint32_t __ramfunc__ sam_iap(uint32_t cmd)
+{
+  uint32_t status;
+  irqstate_t flags;
+
+  flags = up_irq_save();

Review Comment:
   why need up_irq_save here? line 76 is already an atomic operation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to