acassis commented on code in PR #7948:
URL: https://github.com/apache/nuttx/pull/7948#discussion_r1054658408
##########
drivers/leds/Kconfig:
##########
@@ -83,6 +83,55 @@ config RGBLED_LIGHTNESS_CORRECTION
correction which helps the RGB LED visually fade and blend
in a more linear, smooth, and visually appealing fashion.
+config LP503X
+
+ bool "LP503X I2C LED Driver"
+ default n
+ select I2C
+ ---help---
+ Enable support for the TI LP503X LED driver which can be
+ utilized to drive up to 36 (12 RGB) LEDs.
+
+if LP503X
+
+config LP503X_LOG_MODE
+ bool "enable log mode (y) or linear mode (n)"
Review Comment:
```suggestion
bool "Enable logarithmic mode (y) or linear mode (n)"
##########
drivers/leds/Kconfig:
##########
@@ -83,6 +83,55 @@ config RGBLED_LIGHTNESS_CORRECTION
correction which helps the RGB LED visually fade and blend
in a more linear, smooth, and visually appealing fashion.
+config LP503X
+
+ bool "LP503X I2C LED Driver"
+ default n
+ select I2C
+ ---help---
+ Enable support for the TI LP503X LED driver which can be
+ utilized to drive up to 36 (12 RGB) LEDs.
+
+if LP503X
+
+config LP503X_LOG_MODE
+ bool "enable log mode (y) or linear mode (n)"
+ default y
+ ---help---
+ Determines whether brightness scale is logarithmic or linear
+
+config LP503X_POWER_SAVE
+ bool "enable power save mode"
+ default y
+ ---help---
+ Enable/disable automatic power saving mode
+
+config LP503X_DITHER_MODE
+ bool "enable PWM dithering"
Review Comment:
```suggestion
bool "Enable PWM dithering"
##########
drivers/leds/Kconfig:
##########
@@ -83,6 +83,55 @@ config RGBLED_LIGHTNESS_CORRECTION
correction which helps the RGB LED visually fade and blend
in a more linear, smooth, and visually appealing fashion.
+config LP503X
+
+ bool "LP503X I2C LED Driver"
+ default n
+ select I2C
+ ---help---
+ Enable support for the TI LP503X LED driver which can be
+ utilized to drive up to 36 (12 RGB) LEDs.
+
+if LP503X
+
+config LP503X_LOG_MODE
+ bool "enable log mode (y) or linear mode (n)"
Review Comment:
log could be misunderstood as LOG message
##########
drivers/leds/Kconfig:
##########
@@ -83,6 +83,55 @@ config RGBLED_LIGHTNESS_CORRECTION
correction which helps the RGB LED visually fade and blend
in a more linear, smooth, and visually appealing fashion.
+config LP503X
+
+ bool "LP503X I2C LED Driver"
+ default n
+ select I2C
+ ---help---
+ Enable support for the TI LP503X LED driver which can be
+ utilized to drive up to 36 (12 RGB) LEDs.
+
+if LP503X
+
+config LP503X_LOG_MODE
+ bool "enable log mode (y) or linear mode (n)"
+ default y
+ ---help---
+ Determines whether brightness scale is logarithmic or linear
+
+config LP503X_POWER_SAVE
+ bool "enable power save mode"
+ default y
+ ---help---
+ Enable/disable automatic power saving mode
+
+config LP503X_DITHER_MODE
+ bool "enable PWM dithering"
+ default y
+ ---help---
+ Enable/disable PWM dithering mode
+
+config LP503X_MAX_CURRENT
+ bool "enable Max current option (25.5mA (n), or 35mA (y))"
+ default n
+ ---help---
+ Sets maximum output current to 25.5mA (default) or 35mA
+
+config LP503X_GLOBAL_SHUTDOWN
+ bool "enable global LED shutdown"
Review Comment:
```suggestion
bool "Enable global LED shutdown"
##########
drivers/leds/Kconfig:
##########
@@ -83,6 +83,55 @@ config RGBLED_LIGHTNESS_CORRECTION
correction which helps the RGB LED visually fade and blend
in a more linear, smooth, and visually appealing fashion.
+config LP503X
+
+ bool "LP503X I2C LED Driver"
+ default n
+ select I2C
+ ---help---
+ Enable support for the TI LP503X LED driver which can be
+ utilized to drive up to 36 (12 RGB) LEDs.
+
+if LP503X
+
+config LP503X_LOG_MODE
+ bool "enable log mode (y) or linear mode (n)"
+ default y
+ ---help---
+ Determines whether brightness scale is logarithmic or linear
+
+config LP503X_POWER_SAVE
+ bool "enable power save mode"
Review Comment:
```suggestion
bool "Enable power save mode"
##########
drivers/leds/Kconfig:
##########
@@ -83,6 +83,55 @@ config RGBLED_LIGHTNESS_CORRECTION
correction which helps the RGB LED visually fade and blend
in a more linear, smooth, and visually appealing fashion.
+config LP503X
+
+ bool "LP503X I2C LED Driver"
+ default n
+ select I2C
+ ---help---
+ Enable support for the TI LP503X LED driver which can be
+ utilized to drive up to 36 (12 RGB) LEDs.
+
+if LP503X
+
+config LP503X_LOG_MODE
+ bool "enable log mode (y) or linear mode (n)"
+ default y
+ ---help---
+ Determines whether brightness scale is logarithmic or linear
+
+config LP503X_POWER_SAVE
+ bool "enable power save mode"
+ default y
+ ---help---
+ Enable/disable automatic power saving mode
+
+config LP503X_DITHER_MODE
+ bool "enable PWM dithering"
+ default y
+ ---help---
+ Enable/disable PWM dithering mode
+
+config LP503X_MAX_CURRENT
+ bool "enable Max current option (25.5mA (n), or 35mA (y))"
Review Comment:
```suggestion
bool "Enable Max current option (25.5mA (n), or 35mA (y))"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
