yamt commented on PR #7975: URL: https://github.com/apache/nuttx/pull/7975#issuecomment-1364856026
> No, it's problem when CONFIG_SYSTEM_TIME64 is enabled and time_t is map to uint64_t. So, if you don't have a good reason, it's better to map time_t to int64_t like other OS. For !CONFIG_SYSTEM_TIME64 case, time_t is int32_t, but the other side is uint64_t, so it's safe to prompt int32_t(time_t) to uint64_t without warning. * the particular warning in libcxx seems ok to ignore. * anyway, our tree does not seem -Wsign-compare clean regardless of this * IMO consistency within nuttx is a good enough reason -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
