xiaoxiang781216 commented on code in PR #7984:
URL: https://github.com/apache/nuttx/pull/7984#discussion_r1059492535
##########
drivers/segger/sysview.c:
##########
@@ -22,55 +22,94 @@
* Included Files
****************************************************************************/
-#include <nuttx/config.h>
-#include <syslog.h>
-
#include <nuttx/clock.h>
#include <nuttx/sched.h>
#include <nuttx/sched_note.h>
+#include <nuttx/note/note_driver.h>
#include <nuttx/segger/sysview.h>
+#include <stddef.h>
+#include <syslog.h>
#include <SEGGER_RTT.h>
#include <SEGGER_SYSVIEW.h>
#include "sched/sched.h"
/****************************************************************************
- * Private Types
+ * Private Functions
****************************************************************************/
-struct sysview_s
-{
- unsigned int irq[CONFIG_SMP_NCPUS];
-#ifdef CONFIG_SCHED_INSTRUMENTATION_FILTER
- struct note_filter_mode_s mode;
+static void sysview_start(FAR struct note_driver_s *drv,
Review Comment:
let's add note_ prefix to all struct, function, variable and file
name(note_sysview.c)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
