[GitHub] [nuttx] acassis commented on a diff in pull request #8112: libc: Let _SC_PAGESIZE return 4096 when CONFIG_MM_PGSIZE isn't defined

Sat, 14 Jan 2023 07:26:17 -0800 


acassis commented on code in PR #8112:
URL: https://github.com/apache/nuttx/pull/8112#discussion_r1070301855


##########
libs/libc/unistd/lib_sysconf.c:
##########
@@ -229,7 +229,7 @@ long sysconf(int name)
 #ifdef CONFIG_MM_PGSIZE
         return CONFIG_MM_PGSIZE;
 #else
-        return 1;
+        return 4096;

Review Comment:
   Please define something like DEFAULT_MM_PGSIZE and return it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to