anchao commented on code in PR #8129:
URL: https://github.com/apache/nuttx/pull/8129#discussion_r1071731272
##########
net/socket/Kconfig:
##########
@@ -43,7 +43,6 @@ config NET_SOLINGER
bool "SO_LINGER socket option"
default n
depends on NET_TCP_WRITE_BUFFERS || NET_UDP_WRITE_BUFFERS
- select NET_TCP_NOTIFIER if NET_TCP
select NET_UDP_NOTIFIER if NET_UDP
Review Comment:
@acassis ,
now all TCP data transmission is carried out by tcp_timer(), so we can
delete the dependence on NET_TCP_NOTIFIER to avoid blocking for user thread.
UDP data transmission does not need to wait for the reply of the ACK
confirmation as long as the data can be sent successfully, so we keep the logic
of NET_UDP_NOTIFIER(txdrain) when udp close
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
