g2gps commented on code in PR #8173: URL: https://github.com/apache/nuttx/pull/8173#discussion_r1080646183
########## libs/libxx/0001-libcxx-enable-support-for-c++11.patch: ########## @@ -0,0 +1,49 @@ +diff --git a/libcxx/src/barrier.cpp b/libcxx/src/barrier.cpp +index 54890b2d797e..13bc65dfb307 100644 +--- a/libcxx/src/barrier.cpp ++++ b/libcxx/src/barrier.cpp Review Comment: As I understand, LLVM still has support for C++11. From `libcxx/include/__config`: ```c++ #ifndef _LIBCPP_STD_VER # if __cplusplus <= 201103L # define _LIBCPP_STD_VER 11 # elif __cplusplus <= 201402L # define _LIBCPP_STD_VER 14 # elif __cplusplus <= 201703L # define _LIBCPP_STD_VER 17 # elif __cplusplus <= 202002L # define _LIBCPP_STD_VER 20 # else # define _LIBCPP_STD_VER 21 // current year, or date of c++2b ratification # endif #endif // _LIBCPP_STD_VER ``` and ```c++ #if defined(_LIBCPP_COMPILER_GCC) && __cplusplus < 201103L #error "libc++ does not support using GCC with C++03. Please enable C++11" #endif ``` I would say that their minimum supported version is C++11 (with GCC). Was the intention to drop C++11 from NuttX, when using the LLVM library? ########## include/unistd.h: ########## @@ -259,7 +259,9 @@ /* Helpers and legacy compatibility definitions */ +#ifndef CONFIG_LIBCXX #define link(p1, p2) symlink((p1), (p2)) Review Comment: Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
