hartmannathan commented on code in PR #8215: URL: https://github.com/apache/nuttx/pull/8215#discussion_r1083464524
########## boards/arm/stm32u5/b-u585i-iot02a/configs/nsh/defconfig: ########## @@ -5,9 +5,7 @@ # You can then do "make savedefconfig" to generate a new defconfig file that includes your # modifications. # -# CONFIG_ARCH_LEDS is not set Review Comment: Ditto ########## boards/z80/z8/z8encore000zco/configs/ostest/defconfig: ########## @@ -31,7 +31,6 @@ CONFIG_RAM_SIZE=65536 CONFIG_START_DAY=28 CONFIG_START_MONTH=11 CONFIG_START_YEAR=2012 -CONFIG_STDIO_DISABLE_BUFFERING=y Review Comment: DItto ########## boards/arm/stm32wl5/nucleo-wl55jc/configs/fb/defconfig: ########## @@ -33,12 +33,9 @@ CONFIG_RAM_START=0x20000000 CONFIG_RAW_BINARY=y CONFIG_SPI=y CONFIG_SPI_DRIVER=y -CONFIG_STM32WL5_LPUART1=y -CONFIG_STM32WL5_SPI1=y -CONFIG_STM32WL5_USART1=y - Review Comment: Is it better to change these in this PR? Or separate PR? Or perhaps separate commits of same PR? (I don't have a strong opinion on it. Just asking in case it was missed.) ########## boards/z80/z8/z8f64200100kit/configs/ostest/defconfig: ########## @@ -30,7 +30,6 @@ CONFIG_RAM_SIZE=65536 CONFIG_START_DAY=17 CONFIG_START_MONTH=2 CONFIG_START_YEAR=2008 -CONFIG_STDIO_DISABLE_BUFFERING=y Review Comment: Ditto ########## boards/z80/z180/p112/configs/ostest/defconfig: ########## @@ -26,7 +26,6 @@ CONFIG_RAM_START=0x0000 CONFIG_START_DAY=21 CONFIG_START_MONTH=2 CONFIG_START_YEAR=2007 -CONFIG_STDIO_DISABLE_BUFFERING=y Review Comment: Ditto ########## boards/z80/z80/z80sim/configs/ostest/defconfig: ########## @@ -26,7 +26,6 @@ CONFIG_RAM_START=0x0000 CONFIG_START_DAY=21 CONFIG_START_MONTH=2 CONFIG_START_YEAR=2007 -CONFIG_STDIO_DISABLE_BUFFERING=y Review Comment: Ditto. ########## boards/hc/m9s12/ne64badge/configs/ostest/defconfig: ########## @@ -40,7 +40,6 @@ CONFIG_SCI0_TXBUFSIZE=32 CONFIG_START_DAY=11 CONFIG_START_MONTH=12 CONFIG_START_YEAR=2009 -CONFIG_STDIO_DISABLE_BUFFERING=y Review Comment: Ditto -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
