xiaoxiang781216 commented on code in PR #8224:
URL: https://github.com/apache/nuttx/pull/8224#discussion_r1087388498
##########
sched/signal/sig_tgkill.c:
##########
@@ -67,14 +65,13 @@
*
****************************************************************************/
-int pthread_kill(pthread_t thread, int signo)
+int tgkill(pid_t pid, pid_t tid, int signo)
Review Comment:
> Do we need to add `UNUSED(pid);` or put
>
If there is no warning, why add it?
> ```
> #ifdef CONFIG_SCHED_HAVE_PARENT
> if (pid != (pid_t)-1)
> {
> DEBUGASSERT(pid == rtcb->pid);
> }
> #endif
> ```
>
> ?
Can not, since pid mean the main task pid, not the calling thread tid if it
isn't -1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
