anchao commented on code in PR #8439: URL: https://github.com/apache/nuttx/pull/8439#discussion_r1097354992
########## arch/arm/src/rp2040/rp2040_serial.c: ########## @@ -884,8 +884,7 @@ static bool up_rxavailable(struct uart_dev_s *dev) static void up_send(struct uart_dev_s *dev, int ch) { - struct up_dev_s *priv = (struct up_dev_s *)dev->priv; - up_serialout(priv, RP2040_UART_UARTDR_OFFSET, (uint32_t)ch); + up_putc(ch); Review Comment: Done, use arm_lowputc() instead of up_putc() -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org