pkarashchenko commented on code in PR #8440: URL: https://github.com/apache/nuttx/pull/8440#discussion_r1097449933
########## include/fcntl.h: ########## @@ -112,6 +112,18 @@ #define FD_CLOEXEC 1 +/* The flag for openat, faccessat, ... */ + +#define AT_FDCWD -100 /* Special value used to indicate openat should use the current + * working directory. + */ +#define AT_SYMLINK_NOFOLLOW 0x100 /* Do not follow symbolic links. */ +#define AT_EACCESS 0x200 /* Test access permitted for effective IDs, not real IDs. */ +#define AT_REMOVEDIR 0x200 /* Remove directory instead of unlinking file. */ +#define AT_SYMLINK_FOLLOW 0x400 /* Follow symbolic links. */ +#define AT_NO_AUTOMOUNT 0x800 /* Suppress terminal automount traversal */ Review Comment: ```suggestion #define AT_SYMLINK_NOFOLLOW 0x0100 /* Do not follow symbolic links. */ #define AT_EACCESS 0x0200 /* Test access permitted for effective IDs, not real IDs. */ #define AT_REMOVEDIR 0x0200 /* Remove directory instead of unlinking file. */ #define AT_SYMLINK_FOLLOW 0x0400 /* Follow symbolic links. */ #define AT_NO_AUTOMOUNT 00x800 /* Suppress terminal automount traversal */ ``` Is it intentional that `AT_EACCESS` and `AT_REMOVEDIR` share the same value? ########## libs/libc/misc/lib_fstatat.c: ########## @@ -0,0 +1,84 @@ +/**************************************************************************** + * libs/libc/misc/lib_fstatat.c + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <errno.h> +#include <fcntl.h> +#include <sys/stat.h> + +#include "libc.h" + +/**************************************************************************** + * Public Functions + ****************************************************************************/ + +/**************************************************************************** + * Name: fstatat + * + * Description: + * The fstatat() system call operates in exactly the same way as stat(), + * except for the differences described here. + * + * If the pathname given in pathname is relative, then it is interpreted + * relative to the directory referred to by the file descriptor dirfd + * (rather than relative to the current working directory of the calling + * process) + * + * If pathname is relative and dirfd is the special value AT_FDCWD, then + * pathname is interpreted relative to the current working directory of + * the calling process (like stat()). + * + * If pathname is absolute, then dirfd is ignored. + * + * Input Parameters: + * dirfd - The file descriptor of directory. + * path - A pointer to the path. + * buf - The buf to get file status. + * flags - Ignored. + * + * Returned Value: + * Return zero on success, or -1 if an error occurred (in which case, + * errno is set appropriately). + * + ****************************************************************************/ + +int fstatat(int dirfd, FAR const char *path, FAR struct stat *buf, + int flags) +{ + char fullpath[PATH_MAX]; + int ret; + + ret = lib_getfullpath(dirfd, path, fullpath); + if (ret < 0) + { + set_errno(-ret); + return ERROR; + } + + if (flags & AT_SYMLINK_NOFOLLOW) Review Comment: Optional ```suggestion if ((flags & AT_SYMLINK_NOFOLLOW) != 0) ``` ########## libs/libc/misc/lib_getfullpath.c: ########## @@ -0,0 +1,93 @@ +/**************************************************************************** + * libs/libc/misc/lib_getfullpath.c + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> + +#include <fcntl.h> +#include <stdlib.h> +#include <string.h> + +#include "libc.h" + +/**************************************************************************** + * Public Functions + ****************************************************************************/ + +/**************************************************************************** + * Name: lib_getfullpath + * + * Description: + * Given the directory path from dirfd. + * + ****************************************************************************/ + +int lib_getfullpath(int dirfd, FAR const char *path, FAR char *fullpath) +{ + if (path == NULL || fullpath == NULL) + { + return -EINVAL; + } + else if (path[0] == '/') + { + /* The path is absolute, then dirfd is ignored. */ + + strlcpy(fullpath, path, PATH_MAX); + return 0; + } + + if (dirfd == AT_FDCWD) + { + /* The dirfd is the special value AT_FDCWD, then pathname is + * interpreted relative to the current working directory of the + * calling process. + */ + + FAR char *pwd = ""; + +#ifndef CONFIG_DISABLE_ENVIRON + pwd = getenv("PWD"); + if (pwd == NULL) + { + pwd = CONFIG_LIBC_HOMEDIR; + } +#endif + + sprintf(fullpath, "%s/%s", pwd, path); + return 0; + } + else + { + int ret; + + /* Get real directory path by dirfd */ + + ret = fcntl(dirfd, F_GETPATH, fullpath); + if (ret >= 0) + { + strlcat(fullpath, path, PATH_MAX); + } + + return ret; Review Comment: Do we need `return ret;` or `return OK;` here? ########## libs/libc/misc/lib_fchmodat.c: ########## @@ -0,0 +1,83 @@ +/**************************************************************************** + * libs/libc/misc/lib_fchmodat.c + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <errno.h> +#include <fcntl.h> +#include <sys/stat.h> + +#include "libc.h" + +/**************************************************************************** + * Public Functions + ****************************************************************************/ + +/**************************************************************************** + * Name: fchmodat + * + * Description: + * The fchmodat() system call operates in exactly the same way as chmod(), + * except for the differences described here. + * + * If the pathname given in pathname is relative, then it is interpreted + * relative to the directory referred to by the file descriptor dirfd + * (rather than relative to the current working directory of the calling + * process) + * + * If pathname is relative and dirfd is the special value AT_FDCWD, then + * pathname is interpreted relative to the current working directory of + * the calling process (like chmod()). + * + * If pathname is absolute, then dirfd is ignored. + * + * Input Parameters: + * dirfd - The file descriptor of directory. + * path - A pointer to the path. + * mode - The access mode. + * flags - Ignored. + * + * Returned Value: + * Return zero on success, or -1 if an error occurred (in which case, + * errno is set appropriately). + * + ****************************************************************************/ + +int fchmodat(int dirfd, FAR const char *path, mode_t mode, int flags) +{ + char fullpath[PATH_MAX]; + int ret; + + ret = lib_getfullpath(dirfd, path, fullpath); + if (ret < 0) + { + set_errno(-ret); + return ERROR; + } + + if (flags & AT_SYMLINK_NOFOLLOW) Review Comment: Optional ```suggestion if ((flags & AT_SYMLINK_NOFOLLOW) != 0) ``` ########## libs/libc/unistd/lib_fchownat.c: ########## @@ -0,0 +1,85 @@ +/**************************************************************************** + * libs/libc/unistd/lib_fchownat.c + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <errno.h> +#include <fcntl.h> +#include <unistd.h> + +#include "libc.h" + +/**************************************************************************** + * Public Functions + ****************************************************************************/ + +/**************************************************************************** + * Name: fchownat + * + * Description: + * The fchownat() system call operates in exactly the same way as chown(), + * except for the differences described here. + * + * If the pathname given in pathname is relative, then it is interpreted + * relative to the directory referred to by the file descriptor dirfd + * (rather than relative to the current working directory of the calling + * process) + * + * If pathname is relative and dirfd is the special value AT_FDCWD, then + * pathname is interpreted relative to the current working directory of + * the calling process (like chown()). + * + * If pathname is absolute, then dirfd is ignored. + * + * Input Parameters: + * dirfd - The file descriptor of directory. + * path - A pointer to the path. + * owner - The owner to set. + * group - The group to set. + * flags - Ignored. + * + * Returned Value: + * Return zero on success, or -1 if an error occurred (in which case, + * errno is set appropriately). + * + ****************************************************************************/ + +int fchownat(int dirfd, FAR const char *path, uid_t owner, + gid_t group, int flags) +{ + char fullpath[PATH_MAX]; + int ret; + + ret = lib_getfullpath(dirfd, path, fullpath); + if (ret < 0) + { + set_errno(-ret); + return ERROR; + } + + if (flags & AT_SYMLINK_NOFOLLOW) Review Comment: ```suggestion if ((flags & AT_SYMLINK_NOFOLLOW) != 0) ``` ########## libs/libc/misc/lib_utimensat.c: ########## @@ -0,0 +1,83 @@ +/**************************************************************************** + * libs/libc/misc/lib_utimensat.c + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <errno.h> +#include <sys/stat.h> +#include <fcntl.h> + +#include "libc.h" + +/**************************************************************************** + * Public Functions + ****************************************************************************/ + +/**************************************************************************** + * Name: utimensat + * + * Description: + * The utimensat() system call operates in exactly the same way as + * utimens(), except for the differences described here. + * + * If the pathname given in pathname is relative, then it is interpreted + * relative to the directory referred to by the file descriptor dirfd + * (rather than relative to the current working directory of the calling + * process) + * + * If pathname is relative and dirfd is the special value AT_FDCWD, then + * pathname is interpreted relative to the current working directory of + * the calling process (like utimens()). + * + * If pathname is absolute, then dirfd is ignored. + * + * Input Parameters: + * dirfd - The file descriptor of directory. + * path - a pointer to the path. + * flags - the access mode. + * + * Returned Value: + * Return zero on success, or -1 if an error occurred (in which case, + * errno is set appropriately). + * + ****************************************************************************/ + +int utimensat(int dirfd, FAR const char *path, + const struct timespec times[2], int flags) +{ + char fullpath[PATH_MAX]; + int ret; + + ret = lib_getfullpath(dirfd, path, fullpath); + if (ret < 0) + { + set_errno(-ret); + return ERROR; + } + + if (flags & AT_SYMLINK_NOFOLLOW) Review Comment: Optional ```suggestion if ((flags & AT_SYMLINK_NOFOLLOW) != 0) ``` ########## libs/libc/unistd/lib_unlinkat.c: ########## @@ -0,0 +1,85 @@ +/**************************************************************************** + * libs/libc/unistd/lib_unlinkat.c + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <errno.h> +#include <fcntl.h> +#include <unistd.h> + +#include "libc.h" + +/**************************************************************************** + * Public Functions + ****************************************************************************/ + +/**************************************************************************** + * Name: unlinkat + * + * Description: + * The unlinkat() system call operates in exactly the same way as unlink(), + * except for the differences described here. + * + * If the pathname given in pathname is relative, then it is interpreted + * relative to the directory referred to by the file descriptor dirfd + * (rather than relative to the current working directory of the calling + * process) + * + * If pathname is relative and dirfd is the special value AT_FDCWD, then + * pathname is interpreted relative to the current working directory of + * the calling process (like unlink()). + * + * If pathname is absolute, then dirfd is ignored. + * + * If the AT_REMOVEDIR flag is specified, then performs the equivalent + * of rmdir on path. + * + * Input Parameters: + * dirfd - The file descriptor of directory. + * path - A pointer to the path. + * flags - A bit mask. + * + * Returned Value: + * Return zero on success, or -1 if an error occurred (in which case, + * errno is set appropriately). + * + ****************************************************************************/ + +int unlinkat(int dirfd, FAR const char *path, int flags) +{ + char fullpath[PATH_MAX]; + int ret; + + ret = lib_getfullpath(dirfd, path, fullpath); + if (ret < 0) + { + set_errno(-ret); + return ERROR; + } + + if (flags & AT_REMOVEDIR) Review Comment: ```suggestion if ((flags & AT_REMOVEDIR) != 0) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
