xiaoxiang781216 commented on code in PR #8398:
URL: https://github.com/apache/nuttx/pull/8398#discussion_r1103622370
##########
drivers/lcd/Kconfig:
##########
@@ -1104,6 +1104,13 @@ config LCD_RLANDSCAPE
refers one of two orientations where the display is wider than
it is
tall (LCD_LANDSCAPE is the other).
+config LCD_DYN_ORIENTATION
Review Comment:
But the porotype of st7789_lcdinitialize is changed in this patch, which is
an incompatible change. So, I think it's a good chance to let's caller pass in
all parameters(offset, resolution and oerientation) instead by Kconfig.
If the compatibility is required, we can:
```
#define st7789_lcdinitialize(spi) st7789_lcdinitialize2(spi,
CONFIG_LCD_ST7789_XRES, CONFIG_LCD_ST7789_YRES, CONFIG_LCD_ST7789_XOFFSET,
CONFIG_LCD_ST7789_YOFFSET, CONFIG_ST7789_ORIENTATION)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
