This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git


The following commit(s) were added to refs/heads/master by this push:
     new 4ddcb88c65 usbhost: fixed cdcacm issue
4ddcb88c65 is described below

commit 4ddcb88c65b68d7d13d40eaaa32b47db85af3ee0
Author: zhangyuan21 <zhangyua...@xiaomi.com>
AuthorDate: Tue Jan 31 20:54:31 2023 +0800

    usbhost: fixed cdcacm issue
    
    1. fixed cdcacm build issue
    2. unregister uart driver when usbhost destroy
    
    Signed-off-by: zhangyuan21 <zhangyua...@xiaomi.com>
---
 drivers/usbhost/usbhost_cdcacm.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/usbhost/usbhost_cdcacm.c b/drivers/usbhost/usbhost_cdcacm.c
index eb1d695ed1..6607250f29 100644
--- a/drivers/usbhost/usbhost_cdcacm.c
+++ b/drivers/usbhost/usbhost_cdcacm.c
@@ -1223,7 +1223,7 @@ static void usbhost_destroy(FAR void *arg)
   /* Unregister the serial lower half driver */
 
   usbhost_mkdevname(priv, devname);
-#warning Missing logic
+  unregister_driver(devname);
 
   /* Release the device name used by this connection */
 
@@ -2661,11 +2661,10 @@ static bool usbhost_rxflowcontrol(FAR struct uart_dev_s 
*uartdev,
                                   unsigned int nbuffered, bool upper)
 {
   FAR struct usbhost_cdcacm_s *priv;
-  bool newrts;
   int ret;
 
   DEBUGASSERT(uartdev && uartdev->priv);
-  priv = (FAR struct usbhost_cdcacm_s *)uartdev->priv
+  priv = (FAR struct usbhost_cdcacm_s *)uartdev->priv;
 
   /* Is RX flow control enabled? */
 
@@ -2713,9 +2712,9 @@ static bool usbhost_rxflowcontrol(FAR struct uart_dev_s 
*uartdev,
           DEBUGASSERT(ret >= 0);
           UNUSED(ret);
         }
-
-      return false;
     }
+
+  return false;
 }
 #endif
 

Reply via email to