xiaoxiang781216 commented on code in PR #1559:
URL: https://github.com/apache/nuttx-apps/pull/1559#discussion_r1104469786
##########
system/readline/readline_common.c:
##########
@@ -733,7 +749,11 @@ ssize_t readline_common(FAR struct rl_common_s *vtbl, FAR
char *buf,
#ifdef CONFIG_READLINE_ECHO
/* Echo the character to the console */
- RL_PUTC(vtbl, ch);
+ if (rl->outfd > 0)
Review Comment:
zero is valid fd, change all check to >= 0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
