xiaoxiang781216 commented on code in PR #8525:
URL: https://github.com/apache/nuttx/pull/8525#discussion_r1111486687


##########
drivers/note/notesnap_driver.c:
##########
@@ -342,6 +344,19 @@ static void notesnap_syscall_leave(FAR struct 
note_driver_s *drv, int nr,
 }
 #endif
 
+static int notesnap_notifier(FAR struct notifier_block *nb,
+                             unsigned long action, FAR void *data)
+{
+  if (action == PANIC_KERNEL_FINAL)
+    {
+      struct lib_outstream_s stream;
+      lib_lowoutstream(&stream);

Review Comment:
   should we use lib_syslogstream_open?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to