pkarashchenko commented on code in PR #8577: URL: https://github.com/apache/nuttx/pull/8577#discussion_r1112296580
########## boards/arm/samv7/common/include/board_hsmci.h: ########## @@ -59,7 +59,7 @@ extern "C" ****************************************************************************/ int sam_hsmci_initialize(int slotno, int minor, gpio_pinset_t cdcfg, - int cdirq); + int cdirq, bool cdinvert); Review Comment: Yeah. If the different slots have different CD level routing on PCB (I can't imagine why that might happen, but still) then define in board.h is definitely a limitation. I think that the issue appeared when I moved code to the common folder, so the CD level was moved out from board specific. Seems that the current approach is more flexible, let's stick with that for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
