xiaoxiang781216 commented on code in PR #8682:
URL: https://github.com/apache/nuttx/pull/8682#discussion_r1121485280
##########
drivers/note/note_driver.c:
##########
@@ -1390,7 +1394,7 @@ void sched_note_string(uintptr_t ip, FAR const char *buf)
}
}
-void sched_note_dump(uintptr_t ip, uint8_t event,
+void sched_note_dump_ip(uint32_t tag, uintptr_t ip, uint8_t event,
FAR const void *buf, size_t len)
Review Comment:
```suggestion
FAR const void *buf, size_t len)
```
##########
include/nuttx/sched_note.h:
##########
@@ -205,6 +219,29 @@ enum note_type_e
#endif
};
+enum note_tag_e
+{
+ NOTE_TAG_ALWAYS = 0,
+ NOTE_TAG_APP,
+ NOTE_TAG_ARCH,
+ NOTE_TAG_AUDIO,
+ NOTE_TAG_BOARD,
+ NOTE_TAG_CRYPTO,
+ NOTE_TAG_DRIVERS,
+ NOTE_TAG_FS,
+ NOTE_TAG_GRAPHICS,
+ NOTE_TAG_INPUT,
+ NOTE_TAG_MM,
+ NOTE_TAG_NET,
+ NOTE_TAG_SCHED,
+ NOTE_TAG_VIDEO,
+ NOTE_TAG_WIRLESS,
+
+ /* Always last */
+
+ NOTE_TAG_MAX
Review Comment:
NOTE_TAG_LAST,
NOTE_TAG_MAX = NOTE_TAG_LAST + 16
##########
drivers/note/note_driver.c:
##########
@@ -1715,21 +1719,21 @@ void sched_note_vbprintf(uintptr_t ip, uint8_t event,
}
}
-void sched_note_printf(uintptr_t ip,
+void sched_note_printf_ip(uint32_t tag, uintptr_t ip,
FAR const char *fmt, ...)
Review Comment:
```suggestion
FAR const char *fmt, ...)
```
##########
drivers/note/note_driver.c:
##########
@@ -1442,7 +1446,7 @@ void sched_note_dump(uintptr_t ip, uint8_t event,
}
}
-void sched_note_vprintf(uintptr_t ip,
+void sched_note_vprintf_ip(uint32_t tag, uintptr_t ip,
FAR const char *fmt, va_list va)
Review Comment:
```suggestion
FAR const char *fmt, va_list va)
```
##########
drivers/note/note_driver.c:
##########
@@ -1496,7 +1500,7 @@ void sched_note_vprintf(uintptr_t ip,
}
}
-void sched_note_vbprintf(uintptr_t ip, uint8_t event,
+void sched_note_vbprintf_ip(uint32_t tag, uintptr_t ip, uint8_t event,
FAR const char *fmt, va_list va)
Review Comment:
```suggestion
FAR const char *fmt, va_list va)
```
##########
drivers/note/note_driver.c:
##########
@@ -463,7 +466,8 @@ static inline int note_isenabled_dump(void)
/* If the dump trace is disabled, do nothing. */
- if ((g_note_filter.mode.flag & NOTE_FILTER_MODE_FLAG_DUMP) == 0)
+ if ((!(g_note_filter.mode.flag & NOTE_FILTER_MODE_FLAG_DUMP) ||
Review Comment:
```suggestion
if (!(g_note_filter.mode.flag & NOTE_FILTER_MODE_FLAG_DUMP) ||
NOTE_FILTER_DUMPMASK_ISSET(tag, &g_note_filter.tag_mask))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
