no1wudi commented on code in PR #1608:
URL: https://github.com/apache/nuttx-apps/pull/1608#discussion_r1122555742
##########
system/readline/readline_common.c:
##########
@@ -708,11 +708,6 @@ ssize_t readline_common(FAR struct rl_common_s *vtbl, FAR
char *buf,
buf[nch++] = '\n';
buf[nch] = '\0';
-#ifdef CONFIG_READLINE_ECHO
Review Comment:
Maybe should rename it (such as READLINE_VT100) to represent its function
now (cmd history/backspace etc)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
