no1wudi commented on code in PR #8691:
URL: https://github.com/apache/nuttx/pull/8691#discussion_r1123947648
##########
drivers/serial/serial.c:
##########
@@ -886,6 +888,53 @@ static ssize_t uart_read(FAR struct file *filep,
*buffer++ = ch;
recvd++;
+
+ if (dev->isconsole
+#ifdef CONFIG_SERIAL_TERMIOS
+ && (dev->tc_iflag & ECHO)
Review Comment:
Why? What if `dev->isconsole` is false and ECHO not set?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
