Cynerd commented on code in PR #1630: URL: https://github.com/apache/nuttx-apps/pull/1630#discussion_r1128199813
########## Make.defs: ########## @@ -100,6 +100,14 @@ define REGISTER endef endif +# Download + +define DOWNLOAD Review Comment: The updated version now uses `DOWNLOAD` from Nuttix, submitted over here: https://github.com/apache/nuttx/pull/8759. I had to tweak it to allow different output, and I removed the prefix to the reported output. I think that the correct approach is to use the output (the third argument of the `DOWNLOAD` variable). The nothing saying downloads (those have versions as file names) should be replaced by a custom output name. I just skip doing that as part of this PR and we can decide later if we want that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
