no1wudi commented on code in PR #8758:
URL: https://github.com/apache/nuttx/pull/8758#discussion_r1129055457
##########
drivers/serial/uart_rpmsg.c:
##########
@@ -412,8 +412,14 @@ int uart_rpmsg_init(FAR const char *cpuname, FAR const
char *devname,
return ret;
}
+ /* Ignore the `isconsole` to passthrough all UART data,
+ * since the most common usage of rpmsg uart is to communicate with cu
+ * in other processor core, should not do CRLF convertion and ECHO.
+ * Note: you can also change this behavior by termios.
+ */
+
dev->ops = &g_uart_rpmsg_ops;
- dev->isconsole = isconsole;
Review Comment:
If `isconsole` removed, how to achive this ?
```c
sprintf(dev_name, "%s%s", UART_RPMSG_DEV_PREFIX, devname);
uart_register(dev_name, dev);
if (isconsole)
{
uart_register(UART_RPMSG_DEV_CONSOLE, dev);
}
```
We don't know which virtual uart is console or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
