yamt commented on PR #1609: URL: https://github.com/apache/nuttx-apps/pull/1609#issuecomment-1460532489
> > honestly speaking, i feel this is halfly-baked. > > > > * i feel that building wasm modules is not a job of nuttx-apps unless it involves something very nuttx-specific. is there something like that planned? what's that? > > * `CONFIG_BENCHMARK_COREMARK=y` enables both of wasm module build and nuttx-native build of the app. i guess they should be controllable independently. > > * it's awkward to prefer wamr-specific libc implementation over wasi-libc. especially when you use wasi-sdk. > > If you think there are too many problems with the current solution, you can further improve it. I just need an interpretable wasm program to run "hello world". to build a hello world, it's simpler to do: ``` /opt/wasi-sdk/bin/clang -o hello.wasm hello.c ``` > At least no one has implemented this in nuttx before. probably because it isn't desirable? at least i have no motivation to build wasm modules within this repo. just because it's simpler to build them outside. > This will help other junior developers to get familiar with wasm my impression is that, for those who is familiar with building apps for unix-like platforms, it's far simpler to build a wasm module than an nuttx app. mixing them together unnecessarily confuses naive readers, IMO. maybe you can convince me by explaining a bit more about your motivation to build wasm modules within this repo. at this point, i'm feeling that these stuff should be reverted because this repo is to build apps for nuttx, not wasm. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
