pkarashchenko commented on code in PR #8771: URL: https://github.com/apache/nuttx/pull/8771#discussion_r1130187404
########## arch/xtensa/src/esp32s3/esp32s3_systemreset.h: ########## @@ -0,0 +1,105 @@ +/**************************************************************************** + * arch/xtensa/src/esp32s3/esp32s3_systemreset.h + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +#ifndef __ARCH_XTENSA_SRC_ESP32S3_ESP32S3_SYSTEMRESET_H +#define __ARCH_XTENSA_SRC_ESP32S3_ESP32S3_SYSTEMRESET_H + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <stdint.h> + +#ifndef __ASSEMBLY__ Review Comment: If I recall correctly the stdint.h should also be hidden under this ifdef (but maybe things changed from last time I tried it). ########## arch/xtensa/src/esp32s3/esp32s3_wifi_utils.h: ########## @@ -0,0 +1,104 @@ +/**************************************************************************** + * arch/xtensa/src/esp32s3/esp32s3_wifi_utils.h + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#ifndef __ARCH_XTENSA_SRC_ESP32S3_ESP32S3_WIFI_UTILS_H +#define __ARCH_XTENSA_SRC_ESP32S3_ESP32S3_WIFI_UTILS_H + +#include <nuttx/config.h> +#include <nuttx/net/netdev.h> + +#include <stdint.h> Review Comment: ditto -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
