jturnsek commented on code in PR #1648: URL: https://github.com/apache/nuttx-apps/pull/1648#discussion_r1130562612
########## netutils/nng/Makefile: ########## @@ -88,7 +91,8 @@ CSRCS += $(NNG_SRCDIR)/platform/posix/posix_tcpdial.c CSRCS += $(NNG_SRCDIR)/platform/posix/posix_tcplisten.c CSRCS += $(NNG_SRCDIR)/platform/posix/posix_thread.c CSRCS += $(NNG_SRCDIR)/platform/posix/posix_udp.c -CSRCS += $(NNG_SRCDIR)/platform/posix/posix_pollq_epoll.c +#CSRCS += $(NNG_SRCDIR)/platform/posix/posix_pollq_epoll.c Review Comment: I agree that we need to analyse the epoll functionality for possible bugs, but at the same time NNG should work. As NNG supports different mechanisms for event notifications, I suggest we move to poll in order to make example work. AFAIK poll is more efficient in case we have small number of file descriptors. And this is the case here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
