thebolt commented on PR #8755: URL: https://github.com/apache/nuttx/pull/8755#issuecomment-1461515106
The implementation looks ok, at least as far as I can tell without actually running it; however the removal of CONFIG_RAMLOG_CRLF and associated logic seems to be to be the type of externally observable change that should first be discussed on the dev mailing list. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
