pussuw commented on code in PR #8787:
URL: https://github.com/apache/nuttx/pull/8787#discussion_r1133049239
##########
arch/risc-v/src/common/supervisor/riscv_sbi.c:
##########
@@ -87,13 +93,17 @@ static inline uintptr_t sbi_ecall(unsigned int extid,
unsigned int fid,
void riscv_sbi_set_timer(uint64_t stime_value)
{
+#ifdef CONFIG_NUTTSBI
+ sbi_mcall_set_timer(stime_value);
Review Comment:
It is not trivial, I think this level of abstraction is good enough.
`sbi_mcall_set_timer` implements / uses the custom ecall interface. The
reason is, I don't want to make any expectations that the NuttX native SBI will
ever conform to OpenSBI specification.
I still strongly suggest using OpenSBI, but integrating it can be quite a
burden. This is why I made this simple / minimal SBI, because it made (and
makes) developing the kernel mode much faster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
