yamt commented on code in PR #1638: URL: https://github.com/apache/nuttx-apps/pull/1638#discussion_r1136416093
########## interpreters/Wasm.mk: ########## @@ -21,9 +21,14 @@ ifeq ($(WASM_BUILD),y) ifneq ($(CONFIG_INTERPRETERS_WAMR)$(CONFIG_INTERPRETERS_WAMR3),) -WASM_INITIAL_MEMORY ?= 65536 -STACKSIZE ?= $(CONFIG_DEFAULT_TASK_STACKSIZE) -PRIORITY ?= SCHED_PRIORITY_DEFAULT +STACKSIZE ?= $(CONFIG_DEFAULT_TASK_STACKSIZE) +PRIORITY ?= SCHED_PRIORITY_DEFAULT + +ifneq ($(INITMEMORY),) + ifeq ($(shell test $(INITMEMORY) -lt $(STACKSIZE); echo $$?),0) + INITMEMORY := $(shell expr $(STACKSIZE) + $(INITMEMORY)) Review Comment: do you still need this? if a user specifies INITMEMORY smaller than STACKSIZE, it's likely a mistake. i feel it's more user-friendly to just leave the linker complain. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
