pkarashchenko commented on code in PR #8829: URL: https://github.com/apache/nuttx/pull/8829#discussion_r1137767024
########## boards/risc-v/esp32c6/common/scripts/flat_memory.ld: ########## @@ -36,7 +36,7 @@ /* 2nd stage bootloader iram_loader_seg start address */ -#define SRAM_DRAM_END 0x40880000 - I_D_SRAM_OFFSET +#define SRAM_DRAM_END 0x4086e610 - I_D_SRAM_OFFSET Review Comment: Optional ```suggestion #define SRAM_DRAM_END (0x4086e610 - I_D_SRAM_OFFSET) ``` ########## boards/risc-v/espressif/common/scripts/esp32c3_flat_memory.ld: ########## @@ -41,23 +41,13 @@ /* 2nd stage bootloader iram_loader_seg start address */ -#define SRAM_DRAM_END 0x403d0000 - I_D_SRAM_OFFSET +#define SRAM_DRAM_END 0x403ce710 - I_D_SRAM_OFFSET Review Comment: Optional ```suggestion #define SRAM_DRAM_END (0x403ce710 - I_D_SRAM_OFFSET) ``` ########## boards/risc-v/esp32c3/common/scripts/flat_memory.ld: ########## @@ -43,7 +43,7 @@ /* 2nd stage bootloader iram_loader_seg start address */ -#define SRAM_DRAM_END 0x403d0000 - I_D_SRAM_OFFSET +#define SRAM_DRAM_END 0x403ce710 - I_D_SRAM_OFFSET Review Comment: Optional ```suggestion #define SRAM_DRAM_END (0x403ce710 - I_D_SRAM_OFFSET) ``` ########## boards/risc-v/espressif/common/scripts/esp32h2_flat_memory.ld: ########## @@ -31,26 +31,26 @@ #include <nuttx/config.h> -#define SRAM_IRAM_START 0x40800000 -#define SRAM_DRAM_START 0x40800000 +#define SRAM_IRAM_START 0x40800000 +#define SRAM_DRAM_START 0x40800000 -#define I_D_SRAM_OFFSET (SRAM_IRAM_START - SRAM_DRAM_START) +#define I_D_SRAM_OFFSET (SRAM_IRAM_START - SRAM_DRAM_START) /* 2nd stage bootloader iram_loader_seg start address */ -#define SRAM_DRAM_END 0x40850000 - I_D_SRAM_OFFSET +#define SRAM_DRAM_END 0x4083efd0 - I_D_SRAM_OFFSET Review Comment: Optional ```suggestion #define SRAM_DRAM_END (0x4083efd0 - I_D_SRAM_OFFSET) ``` ########## boards/risc-v/espressif/common/scripts/esp32h2_flat_memory.ld: ########## @@ -31,26 +31,26 @@ #include <nuttx/config.h> -#define SRAM_IRAM_START 0x40800000 -#define SRAM_DRAM_START 0x40800000 +#define SRAM_IRAM_START 0x40800000 +#define SRAM_DRAM_START 0x40800000 -#define I_D_SRAM_OFFSET (SRAM_IRAM_START - SRAM_DRAM_START) +#define I_D_SRAM_OFFSET (SRAM_IRAM_START - SRAM_DRAM_START) /* 2nd stage bootloader iram_loader_seg start address */ -#define SRAM_DRAM_END 0x40850000 - I_D_SRAM_OFFSET +#define SRAM_DRAM_END 0x4083efd0 - I_D_SRAM_OFFSET -#define SRAM_IRAM_ORG (SRAM_IRAM_START) -#define SRAM_DRAM_ORG (SRAM_DRAM_START) +#define SRAM_IRAM_ORG (SRAM_IRAM_START) +#define SRAM_DRAM_ORG (SRAM_DRAM_START) -#define I_D_SRAM_SIZE SRAM_DRAM_END - SRAM_DRAM_ORG +#define I_D_SRAM_SIZE SRAM_DRAM_END - SRAM_DRAM_ORG Review Comment: Optional ```suggestion #define I_D_SRAM_SIZE (SRAM_DRAM_END - SRAM_DRAM_ORG) ``` ########## boards/risc-v/espressif/common/scripts/esp32c6_flat_memory.ld: ########## @@ -31,26 +31,26 @@ #include <nuttx/config.h> -#define SRAM_IRAM_START 0x40800000 -#define SRAM_DRAM_START 0x40800000 +#define SRAM_IRAM_START 0x40800000 +#define SRAM_DRAM_START 0x40800000 -#define I_D_SRAM_OFFSET (SRAM_IRAM_START - SRAM_DRAM_START) +#define I_D_SRAM_OFFSET (SRAM_IRAM_START - SRAM_DRAM_START) /* 2nd stage bootloader iram_loader_seg start address */ -#define SRAM_DRAM_END 0x40880000 - I_D_SRAM_OFFSET +#define SRAM_DRAM_END 0x4086e610 - I_D_SRAM_OFFSET -#define SRAM_IRAM_ORG (SRAM_IRAM_START) -#define SRAM_DRAM_ORG (SRAM_DRAM_START) +#define SRAM_IRAM_ORG (SRAM_IRAM_START) +#define SRAM_DRAM_ORG (SRAM_DRAM_START) -#define I_D_SRAM_SIZE SRAM_DRAM_END - SRAM_DRAM_ORG +#define I_D_SRAM_SIZE SRAM_DRAM_END - SRAM_DRAM_ORG Review Comment: Optional ```suggestion #define I_D_SRAM_SIZE (SRAM_DRAM_END - SRAM_DRAM_ORG) ``` ########## boards/risc-v/espressif/common/scripts/esp32c6_flat_memory.ld: ########## @@ -31,26 +31,26 @@ #include <nuttx/config.h> -#define SRAM_IRAM_START 0x40800000 -#define SRAM_DRAM_START 0x40800000 +#define SRAM_IRAM_START 0x40800000 +#define SRAM_DRAM_START 0x40800000 -#define I_D_SRAM_OFFSET (SRAM_IRAM_START - SRAM_DRAM_START) +#define I_D_SRAM_OFFSET (SRAM_IRAM_START - SRAM_DRAM_START) /* 2nd stage bootloader iram_loader_seg start address */ -#define SRAM_DRAM_END 0x40880000 - I_D_SRAM_OFFSET +#define SRAM_DRAM_END 0x4086e610 - I_D_SRAM_OFFSET Review Comment: Optional ```suggestion #define SRAM_DRAM_END (0x4086e610 - I_D_SRAM_OFFSET) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
