acassis commented on code in PR #1557:
URL: https://github.com/apache/nuttx-apps/pull/1557#discussion_r1140380716


##########
crypto/wolfssl/README.md:
##########
@@ -0,0 +1,98 @@
+# NuttX + wolfSSL
+
+## Installation
+
+### Installing from nuttx-apps
+
+Clone wolfssl into the the the crypto/wolfssl folder
+
+```
+git clone https://github.com/wolfSSL/wolfssl.git apps/crypto/wolfssl/wolfssl

Review Comment:
   @jpbland1 the Makefile should do it automatically for the user, please how 
LVGL and others are doing it



##########
crypto/wolfssl/Kconfig:
##########
@@ -0,0 +1,108 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+menuconfig CRYPTO_WOLFSSL
+       bool "wolfSSL SSL/TLS Cryptography Library"
+       default n
+       ---help---
+               Enable support for wolfSSL

Review Comment:
   I think wolfSSL should depends on CONFIG_ALLOW_GPL_COMPONENTS because is it 
not Apache license



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to