pkarashchenko commented on PR #8779:
URL: https://github.com/apache/nuttx/pull/8779#issuecomment-1475891525

   Currently the `arm64_lowputc` is implemented as
   ```
   GTEXT(arm64_lowputc)
   SECTION_FUNC(text, arm64_lowputc)
       ldr   x15, =UART0_BASE_ADDRESS
       early_uart_ready x15, w2
       early_uart_transmit x15, w0
       ret
   ```
   but in C code I see
   ```
   #if defined(CONFIG_UART1_SERIAL_CONSOLE)
   #  define CONSOLE_DEV     g_uart1port         /* UART1 is console */
   #  define TTYS0_DEV       g_uart1port         /* UART1 is ttyS0 */
   #  define UART1_ASSIGNED  1
   #endif
   ```
   So UART0 may be even not a console UART.
   And `UART0_BASE_ADDRESS` is
   ```
    /* Allwinner A64 UART0 Base Address */
   
    #define UART0_BASE_ADDRESS 0x1C28000
   ```
   So what if MCU that is running is not `Allwinner A64`?
   I agree that things are broken, but just do not want to go into "even more 
broken" state


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to