raiden00pl commented on PR #8882: URL: https://github.com/apache/nuttx/pull/8882#issuecomment-1482464901
EP structure definition states that this field is for use by class driver: https://github.com/apache/nuttx/blob/5651715486ed50df92ad3348da92833ac127153c/include/nuttx/usb/usbdev.h#L297 and it is used by all class drivers, eg here: https://github.com/apache/nuttx/blob/5651715486ed50df92ad3348da92833ac127153c/drivers/usbdev/cdcacm.c#L1322 We already store the device reference for all endpoints, so it should be used without problems: https://github.com/apache/nuttx/blob/5651715486ed50df92ad3348da92833ac127153c/arch/arm/src/stm32/stm32_otgfsdev.c#L5252 I'm not sure if this change had any real consequences. I found a lot of problems when running the composite device for stm32 otgdev and it's hard to say which one actually fixed the problem (or maybe all of them together). The strangest thing was that the problems didn't occur on other architectures that I have, only on stm32 OTG and only with the composite class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
