pkarashchenko commented on code in PR #8900:
URL: https://github.com/apache/nuttx/pull/8900#discussion_r1148356110


##########
sched/paging/pg_miss.c:
##########
@@ -179,7 +179,7 @@ void pg_miss(void)
   if (!g_pftcb)
     {
       pginfo("Signaling worker. PID: %d\n", g_pgworker);
-      nxsig_kill(g_pgworker, SIGWORK);
+      nxsig_kill(g_pgworker, SIGIO);

Review Comment:
   Or change `nxthread_setup_scheduler()` and modify line `tcb->sigprocmask = 
rtcb->sigprocmask;` to become
   ```
   if (ttype != TCB_FLAG_TTYPE_KERNEL)
     {
       tcb->sigprocmask = rtcb->sigprocmask;
     }
   else
     {
       tcb->sigprocmask = ALL_SIGNAL_SET;
     }
   ```
   Like, mask all signals for kernel threads. Does this makes sense?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to