pkarashchenko commented on code in PR #1683:
URL: https://github.com/apache/nuttx-apps/pull/1683#discussion_r1148574681


##########
examples/alarm/Kconfig:
##########
@@ -33,6 +33,6 @@ config EXAMPLES_ALARM_DEVPATH
 
 config EXAMPLES_ALARM_SIGNO
        int "Alarm signal"
-       default 1

Review Comment:
   Maybe we can default to `SIGRTMIN`?
   or maybe add some range check to make sure that this is a realtime signal



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to