pkarashchenko commented on code in PR #8913: URL: https://github.com/apache/nuttx/pull/8913#discussion_r1149788224
########## boards/arm/stm32/nucleo-f302r8/configs/qenco/defconfig: ########## @@ -17,24 +71,40 @@ CONFIG_ARCH_INTERRUPTSTACK=1024 CONFIG_ARCH_IRQPRIO=y CONFIG_BOARD_LOOPSPERMSEC=8499 CONFIG_BUILTIN=y -CONFIG_DEBUG_FULLOPT=y +CONFIG_DEBUG_CUSTOMOPT=y +CONFIG_DEBUG_OPTLEVEL="-Os" CONFIG_DEBUG_SYMBOLS=y +CONFIG_DEFAULT_SMALL=y CONFIG_EXAMPLES_QENCODER=y CONFIG_EXAMPLES_QENCODER_HAVE_MAXPOS=y CONFIG_EXAMPLES_QENCODER_MAXPOS=8192 +CONFIG_FILE_STREAM=y CONFIG_INIT_ENTRYPOINT="nsh_main" CONFIG_INTELHEX_BINARY=y +CONFIG_LIBC_FLOATINGPOINT=y +CONFIG_LIBC_LONG_LONG=y +CONFIG_LIBM_TOOLCHAIN=y CONFIG_MQ_MAXMSGSIZE=5 +CONFIG_NSH_ALIAS=y CONFIG_NSH_ARCHINIT=y +CONFIG_NSH_ARGCAT=y CONFIG_NSH_BUILTIN_APPS=y -CONFIG_PREALLOC_TIMERS=4 +CONFIG_NSH_CLE=y +CONFIG_NSH_CMDOPT_HEXDUMP=y +CONFIG_NSH_FILEIOSIZE=1024 +CONFIG_NSH_LINELEN=80 +CONFIG_NSH_QUOTE=y Review Comment: I think that this also can be set to `n` ########## boards/arm/stm32/nucleo-f302r8/configs/qenco/defconfig: ########## @@ -17,24 +71,40 @@ CONFIG_ARCH_INTERRUPTSTACK=1024 CONFIG_ARCH_IRQPRIO=y CONFIG_BOARD_LOOPSPERMSEC=8499 CONFIG_BUILTIN=y -CONFIG_DEBUG_FULLOPT=y +CONFIG_DEBUG_CUSTOMOPT=y +CONFIG_DEBUG_OPTLEVEL="-Os" CONFIG_DEBUG_SYMBOLS=y +CONFIG_DEFAULT_SMALL=y CONFIG_EXAMPLES_QENCODER=y CONFIG_EXAMPLES_QENCODER_HAVE_MAXPOS=y CONFIG_EXAMPLES_QENCODER_MAXPOS=8192 +CONFIG_FILE_STREAM=y CONFIG_INIT_ENTRYPOINT="nsh_main" CONFIG_INTELHEX_BINARY=y +CONFIG_LIBC_FLOATINGPOINT=y +CONFIG_LIBC_LONG_LONG=y +CONFIG_LIBM_TOOLCHAIN=y CONFIG_MQ_MAXMSGSIZE=5 +CONFIG_NSH_ALIAS=y Review Comment: I think we definitely can turn this off -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
