fjpanag commented on code in PR #8911: URL: https://github.com/apache/nuttx/pull/8911#discussion_r1150464696
########## libs/libc/stdio/lib_vasprintf.c: ########## @@ -119,14 +119,18 @@ int vasprintf(FAR char **ptr, FAR const IPTR char *fmt, va_list ap) #endif /* Return a pointer to the string to the caller. NOTE: the memstream put() - * method has already added the NUL terminator to the end of the string + * method has already added the NULL terminator to the end of the string Review Comment: Hmm indeed both seem "correct", although the NULL version is much more widely adopted. I have never seen it before as NUL (or maybe I also considered a typo?). I propose to leave it as is for the moment. If we want to rectify this, then it can be a dedicated PR. I see that there are 163 total occurrences in the code base. So, if it is to be changed, then it should be done for all of them at the same time, for consistency. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
