xiaoxiang781216 commented on code in PR #1692:
URL: https://github.com/apache/nuttx-apps/pull/1692#discussion_r1155126333
##########
interpreters/wamr/Toolchain.defs:
##########
@@ -119,9 +52,16 @@ else ifeq ($(CONFIG_ARCH_SIM),y)
else
WTARGET = x86_64
endif
+else
+
+ # Flags for other architectures (arm or riscv)
+
+ WTARGET = $(LLVM_ARCHTYPE)
+ WCPU = $(LLVM_CPUTYPE)
+
endif
-RCFLAGS += --target=$(WTARGET) $(WCPU)
+RCFLAGS += --target=$(WTARGET) --target-abi=$(LLVM_ABITYPE) --cpu=$(WCPU)
Review Comment:
But many activities are bringing WebAssembly into Linux kernel e.g.:
https://github.com/wasmerio/kernel-wasm
https://github.com/eunomia-bpf/wasm-bpf
BTW, it's wrong to couple Makefile with a particular engine(wamr here).
##########
interpreters/wamr/Toolchain.defs:
##########
@@ -119,9 +52,16 @@ else ifeq ($(CONFIG_ARCH_SIM),y)
else
WTARGET = x86_64
endif
+else
+
+ # Flags for other architectures (arm or riscv)
+
+ WTARGET = $(LLVM_ARCHTYPE)
+ WCPU = $(LLVM_CPUTYPE)
+
endif
-RCFLAGS += --target=$(WTARGET) $(WCPU)
+RCFLAGS += --target=$(WTARGET) --target-abi=$(LLVM_ABITYPE) --cpu=$(WCPU)
Review Comment:
But many activities are bringing WebAssembly into Linux kernel e.g.:
https://github.com/wasmerio/kernel-wasm
https://github.com/eunomia-bpf/wasm-bpf
BTW, it's wrong to couple Makefile with a particular engine(e.g. wamr).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
